Add multiplatform BLE stack for ISO/IEC 18013-5:2021 proximity. #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorotokin
approved these changes
Dec 9, 2024
identity-android/src/main/java/com/android/identity/android/mdoc/transport/L2CAPServer.kt
Show resolved
Hide resolved
davidz25
force-pushed
the
kotlin-mp-transport-abstraction
branch
from
6988867 to
91b9c7c
Compare
kdeus
reviewed
Dec 13, 2024
identity-android/src/main/java/com/android/identity/android/mdoc/transport/L2CAPClient.kt
Outdated
Show resolved
Hide resolved
...ty-doctypes/src/commonMain/kotlin/com/android/identity/documenttype/knowntypes/SampleData.kt
Outdated
Show resolved
Hide resolved
...ty-doctypes/src/commonMain/kotlin/com/android/identity/documenttype/knowntypes/SampleData.kt
Show resolved
Hide resolved
...-mdoc/src/androidMain/kotlin/com/android/identity/mdoc/transport/BleCentralManagerAndroid.kt
Outdated
Show resolved
Hide resolved
...-mdoc/src/androidMain/kotlin/com/android/identity/mdoc/transport/BleCentralManagerAndroid.kt
Show resolved
Hide resolved
...-mdoc/src/androidMain/kotlin/com/android/identity/mdoc/transport/BleCentralManagerAndroid.kt
Show resolved
Hide resolved
...c/src/commonMain/kotlin/com/android/identity/mdoc/transport/BleTransportCentralMdocReader.kt
Outdated
Show resolved
Hide resolved
...mdoc/src/commonMain/kotlin/com/android/identity/mdoc/transport/BleTransportPeripheralMdoc.kt
Outdated
Show resolved
Hide resolved
identity-mdoc/src/iosMain/kotlin/com/android/identity/mdoc/transport/BleCentralManagerIos.kt
Outdated
Show resolved
Hide resolved
...mdoc/src/commonMain/kotlin/com/android/identity/mdoc/transport/BleTransportPeripheralMdoc.kt
Outdated
Show resolved
Hide resolved
davidz25
force-pushed
the
kotlin-mp-transport-abstraction
branch
from
91b9c7c to
f9685eb
Compare
kdeus
approved these changes
Dec 16, 2024
...oc/src/androidMain/kotlin/com/android/identity/mdoc/transport/BlePeripheralManagerAndroid.kt
Outdated
Show resolved
Hide resolved
...oc/src/androidMain/kotlin/com/android/identity/mdoc/transport/BlePeripheralManagerAndroid.kt
Outdated
Show resolved
Hide resolved
identity-mdoc/src/iosMain/kotlin/com/android/identity/mdoc/transport/BleCentralManagerIos.kt
Outdated
Show resolved
Hide resolved
identity-mdoc/src/iosMain/kotlin/com/android/identity/mdoc/transport/BlePeripheralManagerIos.kt
Outdated
Show resolved
Hide resolved
This adds new multiplatform API to the identity-mdoc library for ISO/IEC 18013-5:2021 proximity presentations. It works on both Android and iOS and both operating systems share a lot of common code. Also add support two new pages - "ISO mdoc Proximity Sharing" and "ISO mdoc Proximity Reading" - to the multi-platform test app. This only includes QR engagement, NFC engagement will be added in a future change. These two pages represent feature complete mDL and mDL reader functionality and are designed to work with other implementations as well as with itself. Also introduce `rememberBluetoothPermissionState` composable function and `BluetoothPermissionState` object which can be used to obtain the required permissions on BLE on both Android and iOS. Also devise a new multi-testing framework for automatically testing a number of mDL presentations between two devices. This is available in a new "ISO mdc Multi-Device Testing" page in the test app and the way it works is that the 1st device offers a QR code that the 2nd device scans. This sets up a TCP/IP control plane used for initiating tests, including sharing `DeviceEngagement`. This helps ensure the code is robust and well-tested both for happy paths and with all the various termination options available in the standard. Also modify existing L2CAP support so it follows the latest draft of the upcoming second edition of ISO 18013-5:2021. In particular, this means framing the `SessionData` / `SessionEstablishment` packets sent over the L2CAP socket. Modify `ScanQrCodeDialog` and `ShowQrCodeDialog` so they are easy to extend. Include portrait ans signature images in sample data in identity-doctypes. Test: Manually tested against wallet app and well-known readers. Signed-off-by: David Zeuthen <[email protected]>
davidz25
force-pushed
the
kotlin-mp-transport-abstraction
branch
from
f9685eb to
0c5aa3e
Compare
|
Thanks for the review! Replaced all occurrences of 0x01 and 0x02 with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new multiplatform API to the identity-mdoc library for ISO/IEC 18013-5:2021 proximity presentations. It works on both Android and iOS and both operating systems share a lot of common code.
Also add support two new pages - "ISO mdoc Proximity Sharing" and "ISO mdoc Proximity Reading" - to the multi-platform test app. This only includes QR engagement, NFC engagement will be added in a future change. These two pages represent feature complete mDL and mDL reader functionality and are designed to work with other implementations as well as with itself.
Also introduce
rememberBluetoothPermissionStatecomposable function andBluetoothPermissionStateobject which can be used to obtain the required permissions on BLE on both Android and iOS.Also devise a new multi-testing framework for automatically testing a number of mDL presentations between two devices. This is available in a new "ISO mdc Multi-Device Testing" page in the test app and the way it works is that the 1st device offers a QR code that the 2nd device scans. This sets up a TCP/IP control plane used for initiating tests, including sharing
DeviceEngagement. This helps ensure the code is robust and well-tested both for happy paths and with all the various termination options available in the standard.Also modify existing L2CAP support so it follows the latest draft of the upcoming second edition of ISO 18013-5:2021. In particular, this means framing the
SessionData/SessionEstablishmentpackets sent over the L2CAP socket.Modify
ScanQrCodeDialogandShowQrCodeDialogso they are easy to extend.Include portrait ans signature images in sample data in identity-doctypes.
Test: Manually tested against wallet app and well-known readers.